mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-16 02:38:54 +00:00
Code Issues Projects Releases Wiki Activity

Liquid: eliminate some unnecessary Vector3 field mutations

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-06-20 21:32:24 +01:00
parent d38c17835d
commit 42637f97c6
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/block/Liquid.php
View File

@ -168,7 +168,7 @@ abstract class Liquid extends Transparent{
return $this->flowVector; return $this->flowVector;
} }
$vector = new Vector3(0, 0, 0); $vX = $vY = $vZ = 0;
$decay = $this->getEffectiveFlowDecay($this); $decay = $this->getEffectiveFlowDecay($this);
@ -200,20 +200,22 @@ abstract class Liquid extends Transparent{
if($blockDecay >= 0){ if($blockDecay >= 0){
$realDecay = $blockDecay - ($decay - 8); $realDecay = $blockDecay - ($decay - 8);
$vector->x += ($x - $this->pos->x) * $realDecay; $vX += ($x - $this->pos->x) * $realDecay;
$vector->y += ($y - $this->pos->y) * $realDecay; $vY += ($y - $this->pos->y) * $realDecay;
$vector->z += ($z - $this->pos->z) * $realDecay; $vZ += ($z - $this->pos->z) * $realDecay;
} }
continue; continue;
}else{ }else{
$realDecay = $blockDecay - $decay; $realDecay = $blockDecay - $decay;
$vector->x += ($x - $this->pos->x) * $realDecay; $vX += ($x - $this->pos->x) * $realDecay;
$vector->y += ($y - $this->pos->y) * $realDecay; $vY += ($y - $this->pos->y) * $realDecay;
$vector->z += ($z - $this->pos->z) * $realDecay; $vZ += ($z - $this->pos->z) * $realDecay;
} }
} }
$vector = new Vector3($vX, $vY, $vZ);
if($this->falling){ if($this->falling){
if( if(
!$this->canFlowInto($this->pos->getWorldNonNull()->getBlockAt($this->pos->x, $this->pos->y, $this->pos->z - 1)) or !$this->canFlowInto($this->pos->getWorldNonNull()->getBlockAt($this->pos->x, $this->pos->y, $this->pos->z - 1)) or