From 41f335e7d9b61df0aab68227821a464aea4bb5de Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Thu, 4 Oct 2018 16:24:07 +0100 Subject: [PATCH] Level: Remove setSeed() Seed is immutable information about the world, like its generator type, generator options, name, etc. We don't allow changing any of those things, so why the fuck would we allow changing the seed? This makes no sense at all. I'm removing this because a) its existence makes no sense, and b) it will not produce the behaviour expected from such a function (what even is the expected behaviour???) --- src/pocketmine/level/Level.php | 9 --------- src/pocketmine/level/format/io/BaseLevelProvider.php | 4 ---- src/pocketmine/level/format/io/LevelProvider.php | 5 ----- 3 files changed, 18 deletions(-) diff --git a/src/pocketmine/level/Level.php b/src/pocketmine/level/Level.php index d82bc9cf6..d71d7efb0 100644 --- a/src/pocketmine/level/Level.php +++ b/src/pocketmine/level/Level.php @@ -2864,15 +2864,6 @@ class Level implements ChunkManager, Metadatable{ return $this->provider->getSeed(); } - /** - * Sets the seed for the level - * - * @param int $seed - */ - public function setSeed(int $seed){ - $this->provider->setSeed($seed); - } - public function getWorldHeight() : int{ return $this->worldHeight; } diff --git a/src/pocketmine/level/format/io/BaseLevelProvider.php b/src/pocketmine/level/format/io/BaseLevelProvider.php index 5ecbe032a..c300b71fc 100644 --- a/src/pocketmine/level/format/io/BaseLevelProvider.php +++ b/src/pocketmine/level/format/io/BaseLevelProvider.php @@ -98,10 +98,6 @@ abstract class BaseLevelProvider implements LevelProvider{ return $this->levelData->getLong("RandomSeed"); } - public function setSeed(int $value){ - $this->levelData->setLong("RandomSeed", $value); - } - public function getSpawn() : Vector3{ return new Vector3($this->levelData->getInt("SpawnX"), $this->levelData->getInt("SpawnY"), $this->levelData->getInt("SpawnZ")); } diff --git a/src/pocketmine/level/format/io/LevelProvider.php b/src/pocketmine/level/format/io/LevelProvider.php index 412cfd90d..54c9d9f44 100644 --- a/src/pocketmine/level/format/io/LevelProvider.php +++ b/src/pocketmine/level/format/io/LevelProvider.php @@ -118,11 +118,6 @@ interface LevelProvider{ */ public function getSeed() : int; - /** - * @param int - */ - public function setSeed(int $value); - /** * @return Vector3 */