mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-22 16:51:42 +00:00
Code Issues Projects Releases Wiki Activity

ResourcePackManager: change validity check to is_string()

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-07-17 23:07:37 +01:00
parent 5f70b96081
commit 3e2cfd28cc
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/resourcepacks/ResourcePackManager.php
View File

@ -31,6 +31,7 @@ use function file_exists;
use function gettype;
use function is_array;
use function is_dir;
use function is_string;
use function mkdir;
use function strtolower;
use const DIRECTORY_SEPARATOR;
@ -78,14 +79,11 @@ class ResourcePackManager{
}
foreach($resourceStack as $pos => $pack){
try{
$pack = (string) $pack;
}catch(\ErrorException $e){
if(!is_string($pack)){
$logger->critical("Found invalid entry in resource pack list at offset $pos of type " . gettype($pack));
continue;
}
try{
/** @var string $pack */
$packPath = $this->path . DIRECTORY_SEPARATOR . $pack;
if(!file_exists($packPath)){
throw new ResourcePackException("File or directory not found");