mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-07 12:18:46 +00:00
Code Issues Projects Releases Wiki Activity

Fixed door facing

Browse Source 
this was broken in 1.21.60 update.

should've known better to expect a blockstate upgrade to mean a
blockstate fix...
This commit is contained in:
Dylan K. Taylor 2025-02-24 01:04:05 +00:00
parent 1fed9f6cb5
commit 3df2bdb879
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/data/bedrock/block/convert/BlockStateDeserializerHelper.php
View File

@ -131,7 +131,8 @@ final class BlockStateDeserializerHelper{
//TODO: check if these need any special treatment to get the appropriate data to both halves of the door //TODO: check if these need any special treatment to get the appropriate data to both halves of the door
return $block return $block
->setTop($in->readBool(BlockStateNames::UPPER_BLOCK_BIT)) ->setTop($in->readBool(BlockStateNames::UPPER_BLOCK_BIT))
->setFacing($in->readCardinalHorizontalFacing()) //a door facing "east" is actually facing north - thanks mojang
->setFacing(Facing::rotateY($in->readCardinalHorizontalFacing(), clockwise: false))
->setHingeRight($in->readBool(BlockStateNames::DOOR_HINGE_BIT)) ->setHingeRight($in->readBool(BlockStateNames::DOOR_HINGE_BIT))
->setOpen($in->readBool(BlockStateNames::OPEN_BIT)); ->setOpen($in->readBool(BlockStateNames::OPEN_BIT));
} }

3
src/data/bedrock/block/convert/BlockStateSerializerHelper.php
View File

@ -100,7 +100,8 @@ final class BlockStateSerializerHelper{
public static function encodeDoor(Door $block, Writer $out) : Writer{ public static function encodeDoor(Door $block, Writer $out) : Writer{
return $out return $out
->writeBool(BlockStateNames::UPPER_BLOCK_BIT, $block->isTop()) ->writeBool(BlockStateNames::UPPER_BLOCK_BIT, $block->isTop())
->writeCardinalHorizontalFacing($block->getFacing()) //a door facing north is encoded as "east"
->writeCardinalHorizontalFacing(Facing::rotateY($block->getFacing(), clockwise: true))
->writeBool(BlockStateNames::DOOR_HINGE_BIT, $block->isHingeRight()) ->writeBool(BlockStateNames::DOOR_HINGE_BIT, $block->isHingeRight())
->writeBool(BlockStateNames::OPEN_BIT, $block->isOpen()); ->writeBool(BlockStateNames::OPEN_BIT, $block->isOpen());
} }