mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-10-18 12:04:46 +00:00
Code Issues Projects Releases Wiki Activity

Remove remnants of needACK functionality

Browse Source 
this has been broken for a long time and hasn't been used for even longer.
This commit is contained in:
Dylan K. Taylor
2018-07-20 13:07:06 +01:00
parent 0fecb79add
commit 3cd105ff33
4 changed files with 13 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/pocketmine/Player.php
View File

@@ -1902,7 +1902,7 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
$pk = new PlayStatusPacket();
$pk->status = $status;
$pk->protocol = $this->protocol;
$this->sendDataPacket($pk, false, $immediate);
$this->sendDataPacket($pk, $immediate);
}
public function onVerifyCompleted(LoginPacket $packet, ?string $error, bool $signedByMojang) : void{
@@ -2997,12 +2997,11 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
/**
* @param DataPacket $packet
* @param bool $needACK
* @param bool $immediate
*
* @return bool|int
* @return bool
*/
public function sendDataPacket(DataPacket $packet, bool $needACK = false, bool $immediate = false){
public function sendDataPacket(DataPacket $packet, bool $immediate = false) : bool{
if(!$this->isConnected()){
return false;
}
@@ -3017,22 +3016,20 @@ class Player extends Human implements CommandSender, ChunkLoader, IPlayer{
/**
* @param DataPacket $packet
* @param bool $needACK
*
* @return bool|int
* @return bool
*/
public function dataPacket(DataPacket $packet, bool $needACK = false){
return $this->sendDataPacket($packet, $needACK, false);
public function dataPacket(DataPacket $packet) : bool{
return $this->sendDataPacket($packet, false);
}
/**
* @param DataPacket $packet
* @param bool $needACK
*
* @return bool|int
* @return bool
*/
public function directDataPacket(DataPacket $packet, bool $needACK = false){
return $this->sendDataPacket($packet, $needACK, true);
public function directDataPacket(DataPacket $packet) : bool{
return $this->sendDataPacket($packet, true);
}
/**