mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-12 04:45:12 +00:00
Code Issues Projects Releases Wiki Activity

ContainerTrait: avoid absurdly inefficient use of setItem()

Browse Source 
this substantially improves the performance of loading containers such as chests.
This commit is contained in:
Dylan K. Taylor 2022-01-01 15:05:32 +00:00
parent 72f2c794ab
commit 3c6146b5e0
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/block/tile/ContainerTrait.php
View File

@ -48,11 +48,14 @@ trait ContainerTrait{
$inventory = $this->getRealInventory(); $inventory = $this->getRealInventory();
$listeners = $inventory->getListeners()->toArray(); $listeners = $inventory->getListeners()->toArray();
$inventory->getListeners()->remove(...$listeners); //prevent any events being fired by initialization $inventory->getListeners()->remove(...$listeners); //prevent any events being fired by initialization
$inventory->clearAll();
$newContents = [];
/** @var CompoundTag $itemNBT */ /** @var CompoundTag $itemNBT */
foreach($inventoryTag as $itemNBT){ foreach($inventoryTag as $itemNBT){
$inventory->setItem($itemNBT->getByte("Slot"), Item::nbtDeserialize($itemNBT)); $newContents[$itemNBT->getByte("Slot")] = Item::nbtDeserialize($itemNBT);
} }
$inventory->setContents($newContents);
$inventory->getListeners()->add(...$listeners); $inventory->getListeners()->add(...$listeners);
} }