From 3bdd9ee8608980efa3c135d5992630816cbc363f Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Fri, 19 Jun 2020 10:49:21 +0100 Subject: [PATCH] phpstan: drop a bunch of error patterns that don't appear on 0.12.29+ --- tests/phpstan/configs/phpstan-bugs.neon | 30 ------------------------- 1 file changed, 30 deletions(-) diff --git a/tests/phpstan/configs/phpstan-bugs.neon b/tests/phpstan/configs/phpstan-bugs.neon index e6712299b..a44533241 100644 --- a/tests/phpstan/configs/phpstan-bugs.neon +++ b/tests/phpstan/configs/phpstan-bugs.neon @@ -5,11 +5,6 @@ parameters: count: 1 path: ../../../src/Server.php - - - message: "#^Instanceof between pocketmine\\\\block\\\\tile\\\\Tile and class\\-string\\ will always evaluate to true\\.$#" - count: 1 - path: ../../../src/block/Block.php - - message: "#^Comparison operation \"\\>\\=\" between 0 and 2 is always false\\.$#" count: 1 @@ -30,31 +25,6 @@ parameters: count: 1 path: ../../../src/entity/projectile/Projectile.php - - - message: "#^If condition is always false\\.$#" - count: 1 - path: ../../../src/network/mcpe/protocol/types/entity/EntityMetadataCollection.php - - - - message: "#^Instanceof between pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\entity\\\\MetadataProperty and pocketmine\\\\network\\\\mcpe\\\\protocol\\\\types\\\\entity\\\\MetadataProperty will always evaluate to true\\.$#" - count: 1 - path: ../../../src/network/mcpe/protocol/types/entity/EntityMetadataCollection.php - - - - message: "#^Class pocketmine\\\\item\\\\LegacyStringToItemParser constructor invoked with 0 parameters, 1 required\\.$#" - count: 1 - path: ../../../src/item/LegacyStringToItemParser.php - - - - message: "#^Class pocketmine\\\\network\\\\mcpe\\\\StaticPacketCache constructor invoked with 0 parameters, 2 required\\.$#" - count: 1 - path: ../../../src/network/mcpe/StaticPacketCache.php - - - - message: "#^Class pocketmine\\\\network\\\\mcpe\\\\compression\\\\ZlibCompressor constructor invoked with 0 parameters, 3 required\\.$#" - count: 1 - path: ../../../src/network/mcpe/compression/ZlibCompressor.php - - message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1