mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 18:32:55 +00:00
Code Issues Projects Releases Wiki Activity

Added a mechanism for blocks to detect dynamic state properties from surroundings

Browse Source
This commit is contained in:
Dylan K. Taylor
2018-10-26 15:57:32 +01:00
parent b2201c8c59
commit 3af293f024
6 changed files with 63 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/pocketmine/block/Door.php
View File

@ -69,11 +69,10 @@ abstract class Door extends Transparent{
return 0b1111;
}
/**
* Copies door properties from the other half of the door, since metadata is split between the two halves.
* TODO: the blockstate should be updated directly on creation so these properties can be detected in advance.
*/
private function updateStateFromOtherHalf() : void{
public function updateState() : void{
parent::updateState();
//copy door properties from other half
$other = $this->getSide($this->top ? Facing::DOWN : Facing::UP);
if($other instanceof Door and $other->isSameType($this)){
if($this->top){
@ -91,8 +90,6 @@ abstract class Door extends Transparent{
}
protected function recalculateBoundingBox() : ?AxisAlignedBB{
$this->updateStateFromOtherHalf();
return AxisAlignedBB::one()
->extend(Facing::UP, 1)
->trim($this->open ? Facing::rotate($this->facing, Facing::AXIS_Y, !$this->hingeRight) : $this->facing, 13 / 16);
@ -135,7 +132,6 @@ abstract class Door extends Transparent{
}
public function onActivate(Item $item, Player $player = null) : bool{
$this->updateStateFromOtherHalf();
$this->open = !$this->open;
$other = $this->getSide($this->top ? Facing::DOWN : Facing::UP);