mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-16 18:59:00 +00:00
Code Issues Projects Releases Wiki Activity

Do not mutate the result of Permission->getChildren()

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-11-27 20:28:36 +00:00
parent f0e43a6b22
commit 3849756993
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/permission/DefaultPermissions.php
View File

@ -28,7 +28,7 @@ abstract class DefaultPermissions{
public static function registerPermission(Permission $perm, ?Permission $parent = null) : Permission{ public static function registerPermission(Permission $perm, ?Permission $parent = null) : Permission{
if($parent instanceof Permission){ if($parent instanceof Permission){
$parent->getChildren()[$perm->getName()] = true; $parent->addChild($perm->getName(), true);
} }
PermissionManager::getInstance()->addPermission($perm); PermissionManager::getInstance()->addPermission($perm);

5
src/permission/Permission.php
View File

@ -116,4 +116,9 @@ class Permission{
$p->recalculatePermissions(); $p->recalculatePermissions();
} }
} }
public function addChild(string $name, bool $value) : void{
$this->children[$name] = $value;
$this->recalculatePermissibles();
}
} }