mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-03 00:25:04 +00:00
Code Issues Projects Releases Wiki Activity

Apply typehints to all AsyncTask methods

Browse Source 
Since we're breaking API here anyway, no point in holding back on this.
This commit is contained in:
Dylan K. Taylor
2018-09-10 15:54:01 +01:00
parent d62e00cc74
commit 37190c9a65
11 changed files with 23 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/plugins/TesterPlugin/src/pmmp/TesterPlugin/tests/AsyncTaskMainLoggerTest.php
View File

@ -39,7 +39,7 @@ class AsyncTaskMainLoggerTest extends Test{
$this->storeLocal($testObject);
}
public function onRun(){
public function onRun() : void{
ob_start();
MainLogger::getLogger()->info("Testing");
if(strpos(ob_get_contents(), "Testing") !== false){
@ -48,7 +48,7 @@ class AsyncTaskMainLoggerTest extends Test{
ob_end_flush();
}
public function onCompletion(){
public function onCompletion() : void{
/** @var AsyncTaskMainLoggerTest $test */
$test = $this->fetchLocal();
$test->setResult($this->success ? Test::RESULT_OK : Test::RESULT_FAILED);

2
tests/plugins/TesterPlugin/src/pmmp/TesterPlugin/tests/AsyncTaskMemoryLeakTest.php
View File

@ -50,7 +50,7 @@ class AsyncTaskMemoryLeakTest extends Test{
class TestAsyncTask extends AsyncTask{
public static $destroyed = false;
public function onRun(){
public function onRun() : void{
usleep(50 * 1000); //1 server tick
}