mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-08 20:58:34 +00:00
Code Issues Projects Releases Wiki Activity

CompressorWorker: isolate thread body inside static function

Browse Source 
this prevents accidental access to shared properties, which would cost performance.
This commit is contained in:
Dylan K. Taylor 2023-11-13 10:50:33 +00:00
parent 135fe149f0
commit 366968722f
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/network/mcpe/compression/CompressorWorker.php
View File

@ -26,6 +26,7 @@ namespace pocketmine\network\mcpe\compression;
use pmmp\thread\ThreadSafeArray; use pmmp\thread\ThreadSafeArray;
use pocketmine\snooze\SleeperHandler; use pocketmine\snooze\SleeperHandler;
use pocketmine\snooze\SleeperHandlerEntry; use pocketmine\snooze\SleeperHandlerEntry;
use pocketmine\snooze\SleeperNotifier;
use pocketmine\thread\Thread; use pocketmine\thread\Thread;
use pocketmine\utils\AssumptionFailedError; use pocketmine\utils\AssumptionFailedError;
use function count; use function count;
@ -82,10 +83,14 @@ final class CompressorWorker{
public function onRun() : void{ public function onRun() : void{
/** @var Compressor $compressor */ /** @var Compressor $compressor */
$compressor = unserialize($this->compressor); $compressor = unserialize($this->compressor);
$inChannel = $this->inChannel; self::thread($this->inChannel, $compressor, $this->outChannel, $this->sleeperEntry->createNotifier());
$outChannel = $this->outChannel; }
$sleeperNotifier = $this->sleeperEntry->createNotifier();
/**
* @phpstan-param ThreadSafeArray<int, string|null> $inChannel
* @phpstan-param ThreadSafeArray<int, string> $outChannel
*/
private static function thread(ThreadSafeArray $inChannel, Compressor $compressor, ThreadSafeArray $outChannel, SleeperNotifier $sleeperNotifier) : void{
$shutdown = false; $shutdown = false;
while(!$shutdown){ while(!$shutdown){