mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-03 00:25:04 +00:00
Code Issues Projects Releases Wiki Activity

BlockFactory: change property cache arrays to use regular arrays instead of SplFixedArray

Browse Source 
this does come at a performance cost, but is necessary for metadata expansion.

we finally concede that this is not going to happen without BC breaks, however small they might be ...
This commit is contained in:
Dylan K. Taylor
2022-03-23 15:22:57 +00:00
parent b52bb5016c
commit 334c9daa6a
6 changed files with 55 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/phpunit/block/BlockTest.php
View File

@ -137,7 +137,6 @@ class BlockTest extends TestCase{
*/
public function testLightFiltersValid() : void{
foreach($this->blockFactory->lightFilter as $id => $value){
self::assertNotNull($value, "Light filter value missing for $id");
self::assertLessThanOrEqual(15, $value, "Light filter value for $id is larger than the expected 15");
self::assertGreaterThan(0, $value, "Light filter value for $id must be larger than 0");
}