mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 10:53:05 +00:00
Code Issues Projects Releases Wiki Activity

Bucket: Fixed appearing empty when picking up still liquids

Browse Source 
Buckets already affected by this bug will still appear empty until used. After that they'll work fine.
This commit is contained in:
Dylan K. Taylor
2018-01-03 14:22:53 +00:00
parent db52501462
commit 33352638a9
4 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/pocketmine/item/Bucket.php
View File

@ -59,7 +59,7 @@ class Bucket extends Item implements Consumable{
$stack = clone $this;
$resultItem = $stack->pop();
$resultItem->setDamage($blockClicked->getId());
$resultItem->setDamage($blockClicked->getFlowingForm()->getId());
$player->getServer()->getPluginManager()->callEvent($ev = new PlayerBucketFillEvent($player, $blockReplace, $face, $this, $resultItem));
if(!$ev->isCancelled()){
$player->getLevel()->setBlock($blockClicked, BlockFactory::get(Block::AIR), true, true);
@ -84,7 +84,7 @@ class Bucket extends Item implements Consumable{
$resultItem->setDamage(0);
$player->getServer()->getPluginManager()->callEvent($ev = new PlayerBucketEmptyEvent($player, $blockReplace, $face, $this, $resultItem));
if(!$ev->isCancelled()){
$player->getLevel()->setBlock($blockReplace, $resultBlock, true, true);
$player->getLevel()->setBlock($blockReplace, $resultBlock->getFlowingForm(), true, true);
if($player->isSurvival()){
$player->getInventory()->setItemInHand($ev->getItem());
}