mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-05 17:36:12 +00:00
Code Issues Projects Releases Wiki Activity

Removed RegionLoader::open()

Browse Source 
this is nothing but a source of bugs.
This commit is contained in:
Dylan K. Taylor
2021-04-15 15:38:18 +01:00
parent edb590f681
commit 32c4a165cf
4 changed files with 7 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/phpunit/world/format/io/region/RegionLoaderTest.php
View File

@ -44,7 +44,6 @@ class RegionLoaderTest extends TestCase{
unlink($this->regionPath);
}
$this->region = new RegionLoader($this->regionPath);
$this->region->open();
}
public function tearDown() : void{
@ -65,7 +64,6 @@ class RegionLoaderTest extends TestCase{
$this->region->close();
$r = new RegionLoader($this->regionPath);
$r->open();
self::assertSame($data, $r->readChunk(0, 0));
}
@ -122,12 +120,10 @@ class RegionLoaderTest extends TestCase{
public function testRegionHeaderCachedFilesizeRegression() : void{
$this->region->close();
$region = new RegionLoader($this->regionPath); //now we have a region, so the header will be verified, triggering two filesize() calls
$region->open();
$data = str_repeat("hello", 2000);
$region->writeChunk(0, 0, $data); //add some data to the end of the file, to make the cached filesize invalid
$region->close();
$region = new RegionLoader($this->regionPath);
$region->open();
self::assertSame($data, $region->readChunk(0, 0));
}
}