From 3104a312b25ab19c68066c9688502874f2035a64 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Tue, 27 Feb 2018 16:43:40 +0000 Subject: [PATCH] ConsoleCommandSender: Remove useless function isPlayer() This function is not declared in any useful places (like the CommandSender interface) and it is not present in Player (!!!). Additionally, an is-player check is better done with an instanceof so that type safety is enforced and IDEs can give auto-complete. This is a BC break, but this is such a pointless function that it's probably not even worth mentioning. --- src/pocketmine/command/ConsoleCommandSender.php | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/pocketmine/command/ConsoleCommandSender.php b/src/pocketmine/command/ConsoleCommandSender.php index 0c757cb9e..cb8a1a28a 100644 --- a/src/pocketmine/command/ConsoleCommandSender.php +++ b/src/pocketmine/command/ConsoleCommandSender.php @@ -92,13 +92,6 @@ class ConsoleCommandSender implements CommandSender{ return $this->perm->getEffectivePermissions(); } - /** - * @return bool - */ - public function isPlayer() : bool{ - return false; - } - /** * @return Server */