From 2cad7166b1df41eac9ee7fcbb5065ac037015473 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Tue, 5 Mar 2019 09:30:22 +0000 Subject: [PATCH] GeneratorManager::getGeneratorName() now throws InvalidArgumentException on unregistered generator classes the old behaviour allowed a bug in the world converter to go unnoticed. --- src/pocketmine/level/generator/GeneratorManager.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pocketmine/level/generator/GeneratorManager.php b/src/pocketmine/level/generator/GeneratorManager.php index fbf8fb532..edd38d599 100644 --- a/src/pocketmine/level/generator/GeneratorManager.php +++ b/src/pocketmine/level/generator/GeneratorManager.php @@ -91,6 +91,7 @@ final class GeneratorManager{ * @param string $class Fully qualified name of class that extends \pocketmine\level\generator\Generator * * @return string + * @throws \InvalidArgumentException if the class type cannot be matched to a known alias */ public static function getGeneratorName(string $class) : string{ foreach(self::$list as $name => $c){ @@ -99,7 +100,7 @@ final class GeneratorManager{ } } - return "unknown"; + throw new \InvalidArgumentException("Generator class $class is not registered"); } private function __construct(){