Remove VERSION and GIT_COMMIT constants

these are now lazily computed in VersionInfo as needed.

tests/phpstan/bootstrap.php

@@ -25,6 +25,4 @@ define('pocketmine\_PHPSTAN_ANALYSIS', true);
 
 //TODO: these need to be defined properly or removed
 define('pocketmine\COMPOSER_AUTOLOADER_PATH', dirname(__DIR__, 2) . '/vendor/autoload.php');
-define('pocketmine\GIT_COMMIT', str_repeat('00', 20));
 define('pocketmine\PLUGIN_PATH', '');
-define('pocketmine\VERSION', '9.9.9');

tests/phpstan/configs/check-explicit-mixed-baseline.neon

@@ -30,11 +30,6 @@ parameters:
 			count: 7
 			path: ../../../src/MemoryManager.php
 
-		-
-			message: "#^Cannot access offset 'git' on mixed\\.$#"
-			count: 2
-			path: ../../../src/PocketMine.php
-
 		-
 			message: "#^Cannot cast mixed to int\\.$#"
 			count: 6
@@ -90,6 +85,11 @@ parameters:
 			count: 1
 			path: ../../../src/ServerConfigGroup.php
 
+		-
+			message: "#^Cannot access offset 'git' on mixed\\.$#"
+			count: 2
+			path: ../../../src/VersionInfo.php
+
 		-
 			message: "#^Cannot cast mixed to string\\.$#"
 			count: 1