mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-07 02:21:46 +00:00
Code Issues Projects Releases Wiki Activity

Entity: added a guard to prevent __construct() from running multiple times

Browse Source 
this typically happens due to flawed logic in child classes in plugins which causes parent::__construct() to get called multiple times.
This commit is contained in:
Dylan K. Taylor 2022-03-22 15:33:31 +00:00
parent a5dab0f61e
commit 2b8a54f8ff
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/entity/Entity.php
View File

@ -216,7 +216,13 @@ abstract class Entity{
/** @var int|null */ /** @var int|null */
protected $targetId = null; protected $targetId = null;
private bool $constructorCalled = false;
public function __construct(Location $location, ?CompoundTag $nbt = null){ public function __construct(Location $location, ?CompoundTag $nbt = null){
if($this->constructorCalled){
throw new \LogicException("Attempted to call constructor for an Entity multiple times");
}
$this->constructorCalled = true;
Utils::checkLocationNotInfOrNaN($location); Utils::checkLocationNotInfOrNaN($location);
$this->timings = Timings::getEntityTimings($this); $this->timings = Timings::getEntityTimings($this);