mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-14 01:39:52 +00:00
Code Issues Projects Releases Wiki Activity

Chunk: make setSubChunk() throw exception on invalid Y instead of returning false

Browse Source
This commit is contained in:
Dylan K. Taylor 2019-10-22 21:13:08 +01:00
parent b8c857df64
commit 295d14e0d9
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/world/format/Chunk.php
View File

@ -685,12 +685,10 @@ class Chunk{
* @param int $y * @param int $y
* @param SubChunkInterface|null $subChunk * @param SubChunkInterface|null $subChunk
* @param bool $allowEmpty Whether to check if the chunk is empty, and if so replace it with an empty stub * @param bool $allowEmpty Whether to check if the chunk is empty, and if so replace it with an empty stub
*
* @return bool
*/ */
public function setSubChunk(int $y, ?SubChunkInterface $subChunk, bool $allowEmpty = false) : bool{ public function setSubChunk(int $y, ?SubChunkInterface $subChunk, bool $allowEmpty = false) : void{
if($y < 0 or $y >= $this->height){ if($y < 0 or $y >= $this->height){
return false; throw new \InvalidArgumentException("Invalid subchunk Y coordinate $y");
} }
if($subChunk === null or ($subChunk->isEmpty() and !$allowEmpty)){ if($subChunk === null or ($subChunk->isEmpty() and !$allowEmpty)){
$this->subChunks[$y] = EmptySubChunk::getInstance(); $this->subChunks[$y] = EmptySubChunk::getInstance();
@ -698,7 +696,6 @@ class Chunk{
$this->subChunks[$y] = $subChunk; $this->subChunks[$y] = $subChunk;
} }
$this->setDirtyFlag(self::DIRTY_FLAG_TERRAIN, true); $this->setDirtyFlag(self::DIRTY_FLAG_TERRAIN, true);
return true;
} }
/** /**