mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-13 13:25:16 +00:00
Code Issues Projects Releases Wiki Activity

replacing new Vector3(0, 0, 0) with Vector3::zero() (#5640)

Browse Source
This commit is contained in:
João 2023-03-20 12:54:28 +00:00 committed by GitHub
parent f696a5881b
commit 2751e1ec02
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/entity/Entity.php
View File

@ -246,7 +246,7 @@ abstract class Entity{
if($nbt !== null){ if($nbt !== null){
$this->motion = EntityDataHelper::parseVec3($nbt, self::TAG_MOTION, true); $this->motion = EntityDataHelper::parseVec3($nbt, self::TAG_MOTION, true);
}else{ }else{
$this->motion = new Vector3(0, 0, 0); $this->motion = Vector3::zero();
} }
$this->resetLastMovements(); $this->resetLastMovements();

2
src/entity/EntityDataHelper.php
View File

@ -80,7 +80,7 @@ final class EntityDataHelper{
public static function parseVec3(CompoundTag $nbt, string $tagName, bool $optional) : Vector3{ public static function parseVec3(CompoundTag $nbt, string $tagName, bool $optional) : Vector3{
$pos = $nbt->getTag($tagName); $pos = $nbt->getTag($tagName);
if($pos === null && $optional){ if($pos === null && $optional){
return new Vector3(0, 0, 0); return Vector3::zero();
} }
if(!($pos instanceof ListTag) || ($pos->getTagType() !== NBT::TAG_Double && $pos->getTagType() !== NBT::TAG_Float)){ if(!($pos instanceof ListTag) || ($pos->getTagType() !== NBT::TAG_Double && $pos->getTagType() !== NBT::TAG_Float)){
throw new SavedDataLoadingException("'$tagName' should be a List<Double> or List<Float>"); throw new SavedDataLoadingException("'$tagName' should be a List<Double> or List<Float>");

2
src/entity/projectile/Projectile.php
View File

@ -255,7 +255,7 @@ abstract class Projectile extends Entity{
} }
$this->isCollided = $this->onGround = true; $this->isCollided = $this->onGround = true;
$this->motion = new Vector3(0, 0, 0); $this->motion = Vector3::zero();
}else{ }else{
$this->isCollided = $this->onGround = false; $this->isCollided = $this->onGround = false;
$this->blockHit = null; $this->blockHit = null;

2
src/event/player/PlayerInteractEvent.php
View File

@ -59,7 +59,7 @@ class PlayerInteractEvent extends PlayerEvent implements Cancellable{
$this->player = $player; $this->player = $player;
$this->item = $item; $this->item = $item;
$this->blockTouched = $block; $this->blockTouched = $block;
$this->touchVector = $touchVector ?? new Vector3(0, 0, 0); $this->touchVector = $touchVector ?? Vector3::zero();
$this->blockFace = $face; $this->blockFace = $face;
$this->action = $action; $this->action = $action;
} }

2
src/player/Player.php
View File

@ -1376,7 +1376,7 @@ class Player extends Human implements CommandSender, ChunkListener, IPlayer{
if($this->spawned){ if($this->spawned){
Timings::$playerMove->startTiming(); Timings::$playerMove->startTiming();
$this->processMostRecentMovements(); $this->processMostRecentMovements();
$this->motion = new Vector3(0, 0, 0); //TODO: HACK! (Fixes player knockback being messed up) $this->motion = Vector3::zero(); //TODO: HACK! (Fixes player knockback being messed up)
if($this->onGround){ if($this->onGround){
$this->inAirTicks = 0; $this->inAirTicks = 0;
}else{ }else{