mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 10:22:56 +00:00
Code Issues Projects Releases Wiki Activity

Solved packet encode/decode boilerplate code issue

Browse Source 
Something as simple as forgetting the reset() when encoding would cause lots of problems which could go unnoticed. This should be fully backwards-compatible but needs more tests.
This commit is contained in:
Dylan K. Taylor
2017-07-07 13:59:09 +01:00
parent 1a5e3b2ad0
commit 2726f2a011
88 changed files with 195 additions and 262 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/pocketmine/network/mcpe/protocol/SetTitlePacket.php
View File

@ -45,7 +45,7 @@ class SetTitlePacket extends DataPacket{
public $stayTime = 0;
public $fadeOutTime = 0;
public function decode(){
public function decodePayload(){
$this->type = $this->getVarInt();
$this->text = $this->getString();
$this->fadeInTime = $this->getVarInt();
@ -53,8 +53,7 @@ class SetTitlePacket extends DataPacket{
$this->fadeOutTime = $this->getVarInt();
}
public function encode(){
$this->reset();
public function encodePayload(){
$this->putVarInt($this->type);
$this->putString($this->text);
$this->putVarInt($this->fadeInTime);