mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 10:53:05 +00:00
Code Issues Projects Releases Wiki Activity

Solved packet encode/decode boilerplate code issue

Browse Source 
Something as simple as forgetting the reset() when encoding would cause lots of problems which could go unnoticed. This should be fully backwards-compatible but needs more tests.
This commit is contained in:
Dylan K. Taylor
2017-07-07 13:59:09 +01:00
parent 1a5e3b2ad0
commit 2726f2a011
88 changed files with 195 additions and 262 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/pocketmine/network/mcpe/protocol/ResourcePacksInfoPacket.php
View File

@ -39,7 +39,7 @@ class ResourcePacksInfoPacket extends DataPacket{
/** @var ResourcePack[] */
public $resourcePackEntries = [];
public function decode(){
public function decodePayload(){
/*$this->mustAccept = $this->getBool();
$behaviorPackCount = $this->getLShort();
while($behaviorPackCount-- > 0){
@ -60,8 +60,7 @@ class ResourcePacksInfoPacket extends DataPacket{
}*/
}
public function encode(){
$this->reset();
public function encodePayload(){
$this->putBool($this->mustAccept);
$this->putLShort(count($this->behaviorPackEntries));