mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-05 09:26:06 +00:00
Code Issues Projects Releases Wiki Activity

Solved packet encode/decode boilerplate code issue

Browse Source 
Something as simple as forgetting the reset() when encoding would cause lots of problems which could go unnoticed. This should be fully backwards-compatible but needs more tests.
This commit is contained in:
Dylan K. Taylor
2017-07-07 13:59:09 +01:00
parent 1a5e3b2ad0
commit 2726f2a011
88 changed files with 195 additions and 262 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/pocketmine/network/mcpe/protocol/ResourcePackDataInfoPacket.php
View File

@ -38,7 +38,7 @@ class ResourcePackDataInfoPacket extends DataPacket{
public $compressedPackSize;
public $sha256;
public function decode(){
public function decodePayload(){
$this->packId = $this->getString();
$this->maxChunkSize = $this->getLInt();
$this->chunkCount = $this->getLInt();
@ -46,8 +46,7 @@ class ResourcePackDataInfoPacket extends DataPacket{
$this->sha256 = $this->getString();
}
public function encode(){
$this->reset();
public function encodePayload(){
$this->putString($this->packId);
$this->putLInt($this->maxChunkSize);
$this->putLInt($this->chunkCount);