mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-03 08:39:53 +00:00
Code Issues Projects Releases Wiki Activity

ContainerTrait: improve performance of block destroy hook

Browse Source 
this was creating useless vector3s for every iteration, as well as repeatedly invoking Position->getWorld() for no reason.
This commit is contained in:
Dylan K. Taylor 2022-07-20 20:39:37 +01:00
parent dbc0b9634b
commit 24e72ec109
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/block/tile/ContainerTrait.php
View File

@ -96,8 +96,10 @@ trait ContainerTrait{
$inv = $this->getRealInventory(); $inv = $this->getRealInventory();
$pos = $this->getPosition(); $pos = $this->getPosition();
$world = $pos->getWorld();
$dropPos = $pos->add(0.5, 0.5, 0.5);
foreach($inv->getContents() as $k => $item){ foreach($inv->getContents() as $k => $item){
$pos->getWorld()->dropItem($pos->add(0.5, 0.5, 0.5), $item); $world->dropItem($dropPos, $item);
} }
$inv->clearAll(); $inv->clearAll();
} }