mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-08 04:38:35 +00:00
Code Issues Projects Releases Wiki Activity

PermissibleBase: removed nonsensical code

Browse Source 
it's not possible for this to be null, unless a child class doesn't call the constructor, and anything could break in that case anyway.
This commit is contained in:
Dylan K. Taylor 2018-07-08 13:04:51 +01:00
parent 7ee98ff139
commit 23829952c3
1 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/pocketmine/permission/PermissibleBase.php
View File

@ -30,7 +30,7 @@ use pocketmine\timings\Timings;
class PermissibleBase implements Permissible{ class PermissibleBase implements Permissible{
/** @var ServerOperator */ /** @var ServerOperator */
private $opable = null; private $opable;
/** @var Permissible */ /** @var Permissible */
private $parent = null; private $parent = null;
@ -59,25 +59,15 @@ class PermissibleBase implements Permissible{
* @return bool * @return bool
*/ */
public function isOp() : bool{ public function isOp() : bool{
if($this->opable === null){
return false;
}else{
return $this->opable->isOp(); return $this->opable->isOp();
} }
}
/** /**
* @param bool $value * @param bool $value
*
* @throws \Exception
*/ */
public function setOp(bool $value){ public function setOp(bool $value){
if($this->opable === null){
throw new \LogicException("Cannot change op value as no ServerOperator is set");
}else{
$this->opable->setOp($value); $this->opable->setOp($value);
} }
}
/** /**
* @param Permission|string $name * @param Permission|string $name