mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-22 00:33:59 +00:00
Code Issues Projects Releases Wiki Activity

LightUpdate: micro optimisations opcache isn't smart enough for

Browse Source 
this removes 6 unnecessary opcodes from computeSpreadLight() and 3 from computeRemoveLight(). Tested with opcache.opt_debug_level=0x20000.
This commit is contained in:
Dylan K. Taylor 2021-07-30 23:30:28 +01:00
parent 3319fad863
commit 22c3736d63
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/world/light/LightUpdate.php
View File

@ -167,10 +167,13 @@ abstract class LightUpdate{
protected function computeRemoveLight(int $x, int $y, int $z, int $oldAdjacentLevel, LightPropagationContext $context) : void{
$lightArray = $this->getCurrentLightArray();
$current = $lightArray->get($x & 0xf, $y & 0xf, $z & 0xf);
$lx = $x & 0xf;
$ly = $y & 0xf;
$lz = $z & 0xf;
$current = $lightArray->get($lx, $ly, $lz);
if($current !== 0 and $current < $oldAdjacentLevel){
$lightArray->set($x & 0xf, $y & 0xf, $z & 0xf, 0);
$lightArray->set($lx, $ly, $lz, 0);
if(!isset($context->removalVisited[$index = World::blockHash($x, $y, $z)])){
$context->removalVisited[$index] = true;
@ -188,11 +191,14 @@ abstract class LightUpdate{
protected function computeSpreadLight(int $x, int $y, int $z, int $newAdjacentLevel, LightPropagationContext $context) : void{
$lightArray = $this->getCurrentLightArray();
$current = $lightArray->get($x & 0xf, $y & 0xf, $z & 0xf);
$potentialLight = $newAdjacentLevel - $this->lightFilters[$this->subChunkExplorer->currentSubChunk->getFullBlock($x & 0x0f, $y & 0x0f, $z & 0x0f)];
$lx = $x & 0xf;
$ly = $y & 0xf;
$lz = $z & 0xf;
$current = $lightArray->get($lx, $ly, $lz);
$potentialLight = $newAdjacentLevel - $this->lightFilters[$this->subChunkExplorer->currentSubChunk->getFullBlock($lx, $ly, $lz)];
if($current < $potentialLight){
$lightArray->set($x & 0xf, $y & 0xf, $z & 0xf, $potentialLight);
$lightArray->set($lx, $ly, $lz, $potentialLight);
if(!isset($context->spreadVisited[$index = World::blockHash($x, $y, $z)]) and $potentialLight > 1){
$context->spreadVisited[$index] = true;