diff --git a/src/network/mcpe/protocol/AvailableCommandsPacket.php b/src/network/mcpe/protocol/AvailableCommandsPacket.php index 67fcf2a1f..fcc53843f 100644 --- a/src/network/mcpe/protocol/AvailableCommandsPacket.php +++ b/src/network/mcpe/protocol/AvailableCommandsPacket.php @@ -369,6 +369,9 @@ class AvailableCommandsPacket extends DataPacket implements ClientboundPacket{ } } + /** + * @param string[] $postfixes + */ private function argTypeToString(int $argtype, array $postfixes) : string{ if($argtype & self::ARG_FLAG_VALID){ if($argtype & self::ARG_FLAG_ENUM){ diff --git a/src/network/mcpe/protocol/GameRulesChangedPacket.php b/src/network/mcpe/protocol/GameRulesChangedPacket.php index d53082b9d..198634fe4 100644 --- a/src/network/mcpe/protocol/GameRulesChangedPacket.php +++ b/src/network/mcpe/protocol/GameRulesChangedPacket.php @@ -30,7 +30,7 @@ use pocketmine\network\mcpe\handler\PacketHandler; class GameRulesChangedPacket extends DataPacket implements ClientboundPacket{ public const NETWORK_ID = ProtocolInfo::GAME_RULES_CHANGED_PACKET; - /** @var array */ + /** @var mixed[][] */ public $gameRules = []; protected function decodePayload() : void{ diff --git a/src/network/mcpe/protocol/LevelChunkPacket.php b/src/network/mcpe/protocol/LevelChunkPacket.php index 213d1847b..28d1d4cea 100644 --- a/src/network/mcpe/protocol/LevelChunkPacket.php +++ b/src/network/mcpe/protocol/LevelChunkPacket.php @@ -56,6 +56,9 @@ class LevelChunkPacket extends DataPacket implements ClientboundPacket{ return $result; } + /** + * @param int[] $usedBlobHashes + */ public static function withCache(int $chunkX, int $chunkZ, int $subChunkCount, array $usedBlobHashes, string $extraPayload) : self{ (static function(int ...$hashes){})(...$usedBlobHashes); $result = new self; diff --git a/src/network/mcpe/protocol/LoginPacket.php b/src/network/mcpe/protocol/LoginPacket.php index 57578f57c..51c37bc3f 100644 --- a/src/network/mcpe/protocol/LoginPacket.php +++ b/src/network/mcpe/protocol/LoginPacket.php @@ -87,7 +87,7 @@ class LoginPacket extends DataPacket implements ServerboundPacket{ public $extraData = null; /** @var string */ public $clientDataJwt; - /** @var array decoded payload of the clientData JWT */ + /** @var mixed[] decoded payload of the clientData JWT */ public $clientData = []; /** diff --git a/src/network/mcpe/protocol/StartGamePacket.php b/src/network/mcpe/protocol/StartGamePacket.php index 5669f326a..2b5f36926 100644 --- a/src/network/mcpe/protocol/StartGamePacket.php +++ b/src/network/mcpe/protocol/StartGamePacket.php @@ -103,7 +103,7 @@ class StartGamePacket extends DataPacket implements ClientboundPacket{ public $commandsEnabled; /** @var bool */ public $isTexturePacksRequired = true; - /** @var array */ + /** @var mixed[][] */ public $gameRules = [ //TODO: implement this "naturalregeneration" => [1, false] //Hack for client side regeneration ]; @@ -153,7 +153,7 @@ class StartGamePacket extends DataPacket implements ClientboundPacket{ /** @var ListTag|null */ public $blockTable = null; - /** @var array|null string (name) => int16 (legacyID) */ + /** @var int[]|null string (name) => int16 (legacyID) */ public $itemTable = null; protected function decodePayload() : void{ @@ -300,6 +300,9 @@ class StartGamePacket extends DataPacket implements ClientboundPacket{ $this->putString($this->multiplayerCorrelationId); } + /** + * @param int[] $table + */ private static function serializeItemTable(array $table) : string{ $stream = new NetworkBinaryStream(); $stream->putUnsignedVarInt(count($table)); diff --git a/src/network/mcpe/serializer/NetworkBinaryStream.php b/src/network/mcpe/serializer/NetworkBinaryStream.php index 2bbceec74..1b3c591d8 100644 --- a/src/network/mcpe/serializer/NetworkBinaryStream.php +++ b/src/network/mcpe/serializer/NetworkBinaryStream.php @@ -529,7 +529,7 @@ class NetworkBinaryStream extends BinaryStream{ * Reads gamerules * TODO: implement this properly * - * @return array, members are in the structure [name => [type, value]] + * @return mixed[][], members are in the structure [name => [type, value]] * * @throws BadPacketException * @throws BinaryDataException @@ -564,6 +564,8 @@ class NetworkBinaryStream extends BinaryStream{ /** * Writes a gamerule array, members should be in the structure [name => [type, value]] * TODO: implement this properly + * + * @param mixed[][] $rules */ public function putGameRules(array $rules) : void{ $this->putUnsignedVarInt(count($rules));