Living: drop useless knockBack() parameters, closes #2634

changelogs/4.0-snapshot.md

@@ -152,6 +152,7 @@ This version features substantial changes to the network system, improving coher
 - The following methods have signature changes:
   - `Entity->entityBaseTick()` is now `protected`.
   - `Entity->move()` is now `protected`.
+  - `Living->knockBack()` now accepts `float, float, float` (the first two parameters have been removed).
 - The following classes have been removed:
   - `Creature`
   - `Damageable`

src/pocketmine/entity/Living.php

@@ -579,7 +579,7 @@ abstract class Living extends Entity{
 
 				$deltaX = $this->x - $e->x;
 				$deltaZ = $this->z - $e->z;
-				$this->knockBack($e, $source->getBaseDamage(), $deltaX, $deltaZ, $source->getKnockBack());
+				$this->knockBack($deltaX, $deltaZ, $source->getKnockBack());
 			}
 		}
 
@@ -593,7 +593,7 @@ abstract class Living extends Entity{
 		$this->broadcastEntityEvent(EntityEventPacket::HURT_ANIMATION);
 	}
 
-	public function knockBack(Entity $attacker, float $damage, float $x, float $z, float $base = 0.4) : void{
+	public function knockBack(float $x, float $z, float $base = 0.4) : void{
 		$f = sqrt($x * $x + $z * $z);
 		if($f <= 0){
 			return;

src/pocketmine/item/enchantment/KnockbackEnchantment.php

@@ -38,7 +38,7 @@ class KnockbackEnchantment extends MeleeWeaponEnchantment{
 
 	public function onPostAttack(Entity $attacker, Entity $victim, int $enchantmentLevel) : void{
 		if($victim instanceof Living){
-			$victim->knockBack($attacker, 0, $victim->x - $attacker->x, $victim->z - $attacker->z, $enchantmentLevel * 0.5);
+			$victim->knockBack($victim->x - $attacker->x, $victim->z - $attacker->z, $enchantmentLevel * 0.5);
 		}
 	}
 }