mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 02:08:21 +00:00
Code Issues Projects Releases Wiki Activity

Fixed extremely stupid zero-length bug in BinaryStream

Browse Source 
pls don't kill me 😢
This commit is contained in:
Dylan K. Taylor
2017-06-10 18:33:54 +01:00
parent 4765242397
commit 2024e9ecdf
6 changed files with 23 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/pocketmine/utils/BinaryStream.php
View File

@ -57,19 +57,32 @@ class BinaryStream{
return $this->buffer;
}
public function get(int $len) : string{
if($len < 0){
$this->offset = strlen($this->buffer) - 1;
return "";
}elseif($len === 0){
/**
* @param int|bool $len
*
* @return string
*/
public function get($len) : string{
if($len === true){
$str = substr($this->buffer, $this->offset);
$this->offset = strlen($this->buffer);
return $str;
}elseif($len < 0){
$this->offset = strlen($this->buffer) - 1;
return "";
}elseif($len === 0){
return "";
}
return $len === 1 ? $this->buffer{$this->offset++} : substr($this->buffer, ($this->offset += $len) - $len, $len);
}
public function getRemaining() : string{
$str = substr($this->buffer, $this->offset);
$this->offset = strlen($this->buffer);
return $str;
}
public function put(string $str){
$this->buffer .= $str;
}