mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-16 02:38:54 +00:00
Code Issues Projects Releases Wiki Activity

Disallow plugins disabling other plugins (#5872)

Browse Source
This commit is contained in:
Javier León 2023-07-13 09:44:28 -03:00 committed by GitHub
parent 0d8a06732a
commit 1ffa945fbf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugin/PluginManager.php
View File

@ -486,6 +486,7 @@ class PluginManager{
return true; //TODO: maybe this should be an error? return true; //TODO: maybe this should be an error?
} }
/** @internal */
public function disablePlugins() : void{ public function disablePlugins() : void{
while(count($this->enabledPlugins) > 0){ while(count($this->enabledPlugins) > 0){
foreach($this->enabledPlugins as $plugin){ foreach($this->enabledPlugins as $plugin){
@ -503,7 +504,7 @@ class PluginManager{
} }
} }
public function disablePlugin(Plugin $plugin) : void{ private function disablePlugin(Plugin $plugin) : void{
if($plugin->isEnabled()){ if($plugin->isEnabled()){
$this->server->getLogger()->info($this->server->getLanguage()->translate(KnownTranslationFactory::pocketmine_plugin_disable($plugin->getDescription()->getFullName()))); $this->server->getLogger()->info($this->server->getLanguage()->translate(KnownTranslationFactory::pocketmine_plugin_disable($plugin->getDescription()->getFullName())));
(new PluginDisableEvent($plugin))->call(); (new PluginDisableEvent($plugin))->call();
@ -532,13 +533,6 @@ class PluginManager{
} }
} }
public function clearPlugins() : void{
$this->disablePlugins();
$this->plugins = [];
$this->enabledPlugins = [];
$this->fileAssociations = [];
}
/** /**
* Returns whether the given ReflectionMethod could be used as an event handler. Used to filter methods on Listeners * Returns whether the given ReflectionMethod could be used as an event handler. Used to filter methods on Listeners
* when registering. * when registering.