mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-01 07:39:57 +00:00
Code Issues Projects Releases Wiki Activity

ItemEntity: clone items given to the constructor directly

Browse Source 
this fixes some bizarre mutability issues that occurred when using World->dropItem() with the same object multiple times.
This commit is contained in:
Dylan K. Taylor 2021-12-10 16:31:56 +00:00
parent 6ddaed97fa
commit 1ed9302f5a
No known key found for this signature in database
GPG Key ID: 8927471A91CAFD3D
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/entity/object/ItemEntity.php
View File

@ -68,7 +68,7 @@ class ItemEntity extends Entity{
if($item->isNull()){ if($item->isNull()){
throw new \InvalidArgumentException("Item entity must have a non-air item with a count of at least 1"); throw new \InvalidArgumentException("Item entity must have a non-air item with a count of at least 1");
} }
$this->item = $item; $this->item = clone $item;
parent::__construct($location, $nbt); parent::__construct($location, $nbt);
} }