mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-10 13:35:29 +00:00
Code Issues Projects Releases Wiki Activity

Entity: avoid direct mutation of Vector3 in checkObstruction(), use withComponents() instead

Browse Source 
this ugly code can be simplified quite a lot further, but that's a job for later.
This commit is contained in:
Dylan K. Taylor 2020-09-25 18:38:41 +01:00
parent 25566c2f1a
commit 1d8e7abdd4
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/entity/Entity.php
View File

@ -853,37 +853,37 @@ abstract class Entity{
$force = lcg_value() * 0.2 + 0.1;
if($direction === Facing::WEST){
$this->motion->x = -$force;
$this->motion = $this->motion->withComponents(-$force, null, null);
return true;
}
if($direction === Facing::EAST){
$this->motion->x = $force;
$this->motion = $this->motion->withComponents($force, null, null);
return true;
}
if($direction === Facing::DOWN){
$this->motion->y = -$force;
$this->motion = $this->motion->withComponents(null, -$force, null);
return true;
}
if($direction === Facing::UP){
$this->motion->y = $force;
$this->motion = $this->motion->withComponents(null, $force, null);
return true;
}
if($direction === Facing::NORTH){
$this->motion->z = -$force;
$this->motion = $this->motion->withComponents(null, null, -$force);
return true;
}
if($direction === Facing::SOUTH){
$this->motion->z = $force;
$this->motion = $this->motion->withComponents(null, null, $force);
return true;
}