mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 09:56:06 +00:00
Code Issues Projects Releases Wiki Activity

Remove dead translation code

Browse Source 
we don't translate raw string parameters anywhere else these days, so there's no reason to do so here either. The parameters array is already reduced to string[] by this point anyway.
This commit is contained in:
Dylan K. Taylor
2023-01-08 16:20:05 +00:00
parent ece49f011c
commit 1c96e7936c
2 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/network/mcpe/NetworkSession.php
View File

@ -937,9 +937,6 @@ class NetworkSession{
$language = $this->player->getLanguage(); $language = $this->player->getLanguage();
$parameters = array_map(fn(string|Translatable $p) => $p instanceof Translatable ? $language->translate($p) : $p, $message->getParameters()); $parameters = array_map(fn(string|Translatable $p) => $p instanceof Translatable ? $language->translate($p) : $p, $message->getParameters());
if(!$this->server->isLanguageForced()){ if(!$this->server->isLanguageForced()){
foreach($parameters as $i => $p){
$parameters[$i] = $language->translateString($p, [], "pocketmine.");
}
$this->sendDataPacket(TextPacket::translation($language->translateString($message->getText(), $parameters, "pocketmine."), $parameters)); $this->sendDataPacket(TextPacket::translation($language->translateString($message->getText(), $parameters, "pocketmine."), $parameters));
}else{ }else{
$this->sendDataPacket(TextPacket::raw($language->translateString($message->getText(), $parameters))); $this->sendDataPacket(TextPacket::raw($language->translateString($message->getText(), $parameters)));

3
src/network/mcpe/handler/DeathPacketHandler.php
View File

@ -56,9 +56,6 @@ class DeathPacketHandler extends PacketHandler{
$language = $this->player->getLanguage(); $language = $this->player->getLanguage();
$parameters = array_map(fn(string|Translatable $p) => $p instanceof Translatable ? $language->translate($p) : $p, $this->deathMessage->getParameters()); $parameters = array_map(fn(string|Translatable $p) => $p instanceof Translatable ? $language->translate($p) : $p, $this->deathMessage->getParameters());
if(!$this->player->getServer()->isLanguageForced()){ if(!$this->player->getServer()->isLanguageForced()){
foreach($parameters as $i => $p){
$parameters[$i] = $language->translateString($p, [], "pocketmine.");
}
$message = $language->translateString($this->deathMessage->getText(), $parameters, "pocketmine."); $message = $language->translateString($this->deathMessage->getText(), $parameters, "pocketmine.");
}else{ }else{
$message = $language->translateString($this->deathMessage->getText(), $parameters); $message = $language->translateString($this->deathMessage->getText(), $parameters);