From 1bf5c74053d09fb399d8bbdf629d653930bcb95a Mon Sep 17 00:00:00 2001
From: "Dylan K. Taylor" <odigiman@gmail.com>
Date: Thu, 30 May 2019 19:00:38 +0100
Subject: [PATCH] added missing DaylightSensor tile

---
 src/pocketmine/block/BlockFactory.php        |  3 +-
 src/pocketmine/block/tile/DaylightSensor.php | 48 ++++++++++++++++++++
 src/pocketmine/block/tile/TileFactory.php    |  2 +-
 3 files changed, 51 insertions(+), 2 deletions(-)
 create mode 100644 src/pocketmine/block/tile/DaylightSensor.php

diff --git a/src/pocketmine/block/BlockFactory.php b/src/pocketmine/block/BlockFactory.php
index b25ebd0f5..86b5bccb7 100644
--- a/src/pocketmine/block/BlockFactory.php
+++ b/src/pocketmine/block/BlockFactory.php
@@ -31,6 +31,7 @@ use pocketmine\block\tile\Banner as TileBanner;
 use pocketmine\block\tile\Bed as TileBed;
 use pocketmine\block\tile\Chest as TileChest;
 use pocketmine\block\tile\Comparator as TileComparator;
+use pocketmine\block\tile\DaylightSensor as TileDaylightSensor;
 use pocketmine\block\tile\EnchantTable as TileEnchantingTable;
 use pocketmine\block\tile\EnderChest as TileEnderChest;
 use pocketmine\block\tile\FlowerPot as TileFlowerPot;
@@ -120,7 +121,7 @@ class BlockFactory{
 		self::register(new Cobweb(new BID(Ids::COBWEB), "Cobweb"));
 		self::register(new CocoaBlock(new BID(Ids::COCOA), "Cocoa Block"));
 		self::register(new CraftingTable(new BID(Ids::CRAFTING_TABLE), "Crafting Table"));
-		self::register(new DaylightSensor(new BIDFlattened(Ids::DAYLIGHT_DETECTOR, Ids::DAYLIGHT_DETECTOR_INVERTED), "Daylight Sensor"));
+		self::register(new DaylightSensor(new BIDFlattened(Ids::DAYLIGHT_DETECTOR, Ids::DAYLIGHT_DETECTOR_INVERTED, 0, null, TileDaylightSensor::class), "Daylight Sensor"));
 		self::register(new DeadBush(new BID(Ids::DEADBUSH), "Dead Bush"));
 		self::register(new DetectorRail(new BID(Ids::DETECTOR_RAIL), "Detector Rail"));
 
diff --git a/src/pocketmine/block/tile/DaylightSensor.php b/src/pocketmine/block/tile/DaylightSensor.php
new file mode 100644
index 000000000..d06201654
--- /dev/null
+++ b/src/pocketmine/block/tile/DaylightSensor.php
@@ -0,0 +1,48 @@
+<?php
+
+/*
+ *
+ *  ____            _        _   __  __ _                  __  __ ____
+ * |  _ \ ___   ___| | _____| |_|  \/  (_)_ __   ___      |  \/  |  _ \
+ * | |_) / _ \ / __| |/ / _ \ __| |\/| | | '_ \ / _ \_____| |\/| | |_) |
+ * |  __/ (_) | (__|   <  __/ |_| |  | | | | | |  __/_____| |  | |  __/
+ * |_|   \___/ \___|_|\_\___|\__|_|  |_|_|_| |_|\___|     |_|  |_|_|
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * @author PocketMine Team
+ * @link http://www.pocketmine.net/
+ *
+ *
+*/
+
+declare(strict_types=1);
+
+namespace pocketmine\block\tile;
+
+use pocketmine\nbt\tag\CompoundTag;
+
+/**
+ * @deprecated
+ * As per the wiki, this is an old hack to force daylight sensors to get updated every game tick. This is necessary to
+ * ensure that the daylight sensor's power output is always up to date with the current world time.
+ * It's theoretically possible to implement this without a blockentity, but this is here to ensure that vanilla can
+ * understand daylight sensors in worlds created by PM.
+ */
+class DaylightSensor extends Tile{
+
+	public function readSaveData(CompoundTag $nbt) : void{
+
+	}
+
+	protected function writeSaveData(CompoundTag $nbt) : void{
+
+	}
+
+	public function onUpdate() : bool{
+		return false; //TODO: we'll need this for implementing daylight sensor until https://github.com/pmmp/PocketMine-MP/issues/2099 is fixed
+	}
+}
diff --git a/src/pocketmine/block/tile/TileFactory.php b/src/pocketmine/block/tile/TileFactory.php
index 369260602..811dd719f 100644
--- a/src/pocketmine/block/tile/TileFactory.php
+++ b/src/pocketmine/block/tile/TileFactory.php
@@ -50,6 +50,7 @@ final class TileFactory{
 		self::register(Bed::class, ["Bed", "minecraft:bed"]);
 		self::register(Chest::class, ["Chest", "minecraft:chest"]);
 		self::register(Comparator::class, ["Comparator", "minecraft:comparator"]);
+		self::register(DaylightSensor::class, ["DaylightDetector", "minecraft:daylight_detector"]);
 		self::register(EnchantTable::class, ["EnchantTable", "minecraft:enchanting_table"]);
 		self::register(EnderChest::class, ["EnderChest", "minecraft:ender_chest"]);
 		self::register(FlowerPot::class, ["FlowerPot", "minecraft:flower_pot"]);
@@ -70,7 +71,6 @@ final class TileFactory{
 		//TODO: ChemistryTable
 		//TODO: CommandBlock
 		//TODO: Conduit
-		//TODO: DaylightDetector
 		//TODO: Dispenser
 		//TODO: Dropper
 		//TODO: EndGateway