From 1a24afc6d1b3f2982dca3c654e88351c2d8ab56e Mon Sep 17 00:00:00 2001
From: "Dylan K. Taylor" <dktapps@pmmp.io>
Date: Tue, 2 Feb 2021 00:13:58 +0000
Subject: [PATCH] InventoryTransaction: Fixed indexes persisting from balance
 calculation in crafting input/outputs fixes #4019 the order of the actual
 items may not be the same across runs, but index 0 will at least be sure to
 exist.

---
 src/pocketmine/inventory/transaction/InventoryTransaction.php | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/pocketmine/inventory/transaction/InventoryTransaction.php b/src/pocketmine/inventory/transaction/InventoryTransaction.php
index 053a15712..6d005651a 100644
--- a/src/pocketmine/inventory/transaction/InventoryTransaction.php
+++ b/src/pocketmine/inventory/transaction/InventoryTransaction.php
@@ -30,6 +30,7 @@ use pocketmine\inventory\transaction\action\SlotChangeAction;
 use pocketmine\item\Item;
 use pocketmine\Player;
 use function array_keys;
+use function array_values;
 use function assert;
 use function count;
 use function get_class;
@@ -168,6 +169,8 @@ class InventoryTransaction{
 				}
 			}
 		}
+		$needItems = array_values($needItems);
+		$haveItems = array_values($haveItems);
 	}
 
 	/**