mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-15 02:09:42 +00:00
Code Issues Projects Releases Wiki Activity

Chunk: clean up nonsensical code in initChunk()

Browse Source 
I have no idea why the extra check was there, or why the null assignment was used, because it doesn't make any sense.
This commit is contained in:
Dylan K. Taylor 2019-12-01 21:14:23 +00:00
parent fee3c17148
commit 17037f5e9c
1 changed files with 35 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pocketmine/level/format/Chunk.php
View File

@ -694,7 +694,7 @@ class Chunk{
public function initChunk(Level $level){ public function initChunk(Level $level){
if(!$this->isInit){ if(!$this->isInit){
$changed = false; $changed = false;
if($this->NBTentities !== null){
$level->timings->syncChunkLoadEntitiesTimer->startTiming(); $level->timings->syncChunkLoadEntitiesTimer->startTiming();
foreach($this->NBTentities as $nbt){ foreach($this->NBTentities as $nbt){
if($nbt instanceof CompoundTag){ if($nbt instanceof CompoundTag){
@ -716,6 +716,7 @@ class Chunk{
} }
} }
} }
$this->NBTentities = [];
$level->timings->syncChunkLoadEntitiesTimer->stopTiming(); $level->timings->syncChunkLoadEntitiesTimer->stopTiming();
$level->timings->syncChunkLoadTileEntitiesTimer->startTiming(); $level->timings->syncChunkLoadTileEntitiesTimer->startTiming();
@ -733,12 +734,9 @@ class Chunk{
} }
} }
$this->NBTtiles = [];
$level->timings->syncChunkLoadTileEntitiesTimer->stopTiming(); $level->timings->syncChunkLoadTileEntitiesTimer->stopTiming();
$this->NBTentities = null;
$this->NBTtiles = null;
}
$this->hasChanged = $changed; $this->hasChanged = $changed;
$this->isInit = true; $this->isInit = true;