mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 09:56:06 +00:00
Code Issues Projects Releases Wiki Activity

Clean up block update sending, remove UpdateBlockPacket flag constants

Browse Source 
These flags are not intended for network use, instead they are supposed to be used internally by the game. For network, we only need to care about the 0x02 flag (send to players) because that's necessary for the client to render the block.
This commit is contained in:
Dylan K. Taylor
2018-09-27 15:56:08 +01:00
parent 8a8f1d84ff
commit 16f2ac14b3
3 changed files with 25 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/pocketmine/network/mcpe/protocol/UpdateBlockPacket.php
View File

@ -31,15 +31,6 @@ use pocketmine\network\mcpe\handler\SessionHandler;
class UpdateBlockPacket extends DataPacket{
public const NETWORK_ID = ProtocolInfo::UPDATE_BLOCK_PACKET;
public const FLAG_NONE = 0b0000;
public const FLAG_NEIGHBORS = 0b0001;
public const FLAG_NETWORK = 0b0010;
public const FLAG_NOGRAPHIC = 0b0100;
public const FLAG_PRIORITY = 0b1000;
public const FLAG_ALL = self::FLAG_NEIGHBORS | self::FLAG_NETWORK;
public const FLAG_ALL_PRIORITY = self::FLAG_ALL | self::FLAG_PRIORITY;
public const DATA_LAYER_NORMAL = 0;
public const DATA_LAYER_LIQUID = 1;
@ -51,8 +42,12 @@ class UpdateBlockPacket extends DataPacket{
public $y;
/** @var int */
public $blockRuntimeId;
/** @var int */
public $flags;
/**
* @var int
* Flags are used by MCPE internally for block setting, but only flag 2 (network flag) is relevant for network.
* This field is pointless really.
*/
public $flags = 0x02;
/** @var int */
public $dataLayerId = self::DATA_LAYER_NORMAL;