mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-09 03:06:55 +00:00
Code Issues Projects Releases Wiki Activity

NetworkBinaryStream: fixed crash when non-compound root tag is provided for itemstack

Browse Source
This commit is contained in:
Dylan K. Taylor
2019-12-01 18:41:02 +00:00
parent a4a6d3e094
commit 163ed225f2
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pocketmine/network/mcpe/NetworkBinaryStream.php
View File

@ -93,7 +93,11 @@ class NetworkBinaryStream extends BinaryStream{
if($c !== 1){ if($c !== 1){
throw new \UnexpectedValueException("Unexpected NBT count $c"); throw new \UnexpectedValueException("Unexpected NBT count $c");
} }
$nbt = (new NetworkLittleEndianNBTStream())->read($this->buffer, false, $this->offset, 512); $decodedNBT = (new NetworkLittleEndianNBTStream())->read($this->buffer, false, $this->offset, 512);
if(!($decodedNBT instanceof CompoundTag)){
throw new \UnexpectedValueException("Unexpected root tag type for itemstack");
}
$nbt = $decodedNBT;
}elseif($nbtLen !== 0){ }elseif($nbtLen !== 0){
throw new \UnexpectedValueException("Unexpected fake NBT length $nbtLen"); throw new \UnexpectedValueException("Unexpected fake NBT length $nbtLen");
} }