mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-25 12:54:03 +00:00
Code Issues Projects Releases Wiki Activity

TranslationContainer: remove redundant setters

Browse Source 
i'd like to make this completely immutable, but there are some problems to solve first.
This commit is contained in:
Dylan K. Taylor 2019-07-19 18:09:00 +01:00
parent 99bba66f13
commit 14d79c205b
1 changed files with 6 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/pocketmine/lang/TranslationContainer.php
View File

@ -23,8 +23,6 @@ declare(strict_types=1);
namespace pocketmine\lang; namespace pocketmine\lang;
use function count;
class TranslationContainer extends TextContainer{ class TranslationContainer extends TextContainer{
/** @var string[] $params */ /** @var string[] $params */
@ -37,7 +35,12 @@ class TranslationContainer extends TextContainer{
public function __construct(string $text, array $params = []){ public function __construct(string $text, array $params = []){
parent::__construct($text); parent::__construct($text);
$this->setParameters($params); $i = 0;
foreach($params as $str){
$this->params[$i] = (string) $str;
++$i;
}
} }
/** /**
@ -55,28 +58,4 @@ class TranslationContainer extends TextContainer{
public function getParameter(int $i) : ?string{ public function getParameter(int $i) : ?string{
return $this->params[$i] ?? null; return $this->params[$i] ?? null;
} }
/**
* @param int $i
* @param string $str
*/
public function setParameter(int $i, string $str) : void{
if($i < 0 or $i > count($this->params)){ //Intended, allow to set the last
throw new \InvalidArgumentException("Invalid index $i, have " . count($this->params));
}
$this->params[$i] = $str;
}
/**
* @param string[] $params
*/
public function setParameters(array $params) : void{
$i = 0;
foreach($params as $str){
$this->params[$i] = (string) $str;
++$i;
}
}
} }