mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-13 15:05:33 +00:00
Code Issues Projects Releases Wiki Activity

Inventory->getItem(): Removed useless clones

Browse Source 
this already returns a copy of the item anyway... wtf?
This commit is contained in:
Dylan K. Taylor 2017-09-19 18:49:08 +01:00
parent 8cae20e818
commit 136ab1dba1
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pocketmine/inventory/BaseInventory.php
View File

@ -428,7 +428,7 @@ abstract class BaseInventory implements Inventory{
$pk = new InventorySlotPacket(); $pk = new InventorySlotPacket();
$pk->inventorySlot = $index; $pk->inventorySlot = $index;
$pk->item = clone $this->getItem($index); $pk->item = $this->getItem($index);
foreach($target as $player){ foreach($target as $player){
if(($id = $player->getWindowId($this)) === -1){ if(($id = $player->getWindowId($this)) === -1){

2
src/pocketmine/inventory/PlayerCursorInventory.php
View File

@ -63,7 +63,7 @@ class PlayerCursorInventory extends BaseInventory{
$pk = new InventorySlotPacket(); $pk = new InventorySlotPacket();
$pk->inventorySlot = $index; $pk->inventorySlot = $index;
$pk->item = clone $this->getItem($index); $pk->item = $this->getItem($index);
foreach($target as $player){ foreach($target as $player){
if($player === $this->getHolder()){ if($player === $this->getHolder()){

2
src/pocketmine/inventory/PlayerInventory.php
View File

@ -465,7 +465,7 @@ class PlayerInventory extends BaseInventory{
$pk = new InventorySlotPacket(); $pk = new InventorySlotPacket();
$pk->inventorySlot = $index; $pk->inventorySlot = $index;
$pk->item = clone $this->getItem($index); $pk->item = $this->getItem($index);
foreach($target as $player){ foreach($target as $player){
if($player === $this->getHolder()){ if($player === $this->getHolder()){