From 12dd6adfccfd4f1b41b564a50a0486ac8a9fe513 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 18 Feb 2019 13:27:22 +0000 Subject: [PATCH] Block: Derive light filter level based on isTransparent() return this might be dynamic. --- src/pocketmine/block/Block.php | 2 +- src/pocketmine/block/Transparent.php | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/pocketmine/block/Block.php b/src/pocketmine/block/Block.php index 4a8dff988..947d0d2a1 100644 --- a/src/pocketmine/block/Block.php +++ b/src/pocketmine/block/Block.php @@ -450,7 +450,7 @@ class Block extends Position implements BlockIds, Metadatable{ * @return int 0-15 */ public function getLightFilter() : int{ - return 15; + return $this->isTransparent() ? 0 : 15; } /** diff --git a/src/pocketmine/block/Transparent.php b/src/pocketmine/block/Transparent.php index 8654cc400..d079f39f9 100644 --- a/src/pocketmine/block/Transparent.php +++ b/src/pocketmine/block/Transparent.php @@ -29,8 +29,4 @@ abstract class Transparent extends Block{ public function isTransparent() : bool{ return true; } - - public function getLightFilter() : int{ - return 0; - } }