mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-12 16:59:44 +00:00
Code Issues Projects Releases Wiki Activity

Automate creation of tiles when they are used to store block properties

Browse Source
This commit is contained in:
Dylan K. Taylor 2018-10-29 18:20:05 +00:00
parent 3f3bdaeba5
commit 1170b66fd5
8 changed files with 76 additions and 80 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/pocketmine/block/Bed.php
View File

@ -74,16 +74,24 @@ class Bed extends Transparent{
return 0b1111;
}
public function updateState() : void{
parent::updateState();
public function readStateFromWorld() : void{
parent::readStateFromWorld();
//read extra state information from the tile - this is an ugly hack
//TODO: extend this hack to setting block as well so we don't have to deal with tile hacks in the main code
$tile = $this->level->getTile($this);
if($tile instanceof TileBed){
$this->color = $tile->getColor();
}
}
public function writeStateToWorld() : void{
parent::writeStateToWorld();
//extra block properties storage hack
$tile = Tile::createTile(Tile::BED, $this->getLevel(), TileBed::createNBT($this));
if($tile instanceof TileBed){
$tile->setColor($this->color);
}
}
public function getHardness() : float{
return 0.2;
}
@ -186,16 +194,6 @@ class Bed extends Transparent{
$nextState->head = true;
$this->getLevel()->setBlock($next, $nextState);
//TODO: make this happen automatically on block set
$tile1 = Tile::createTile(Tile::BED, $this->getLevel(), TileBed::createNBT($this));
if($tile1 instanceof TileBed){
$tile1->setColor($this->color);
}
$tile2 = Tile::createTile(Tile::BED, $this->getLevel(), TileBed::createNBT($next));
if($tile2 instanceof TileBed){
$tile2->setColor($this->color);
}
return true;
}
}

30
src/pocketmine/block/Block.php
View File

@ -149,6 +149,22 @@ class Block extends Position implements BlockIds, Metadatable{
//NOOP
}
/**
* Called when this block is created, set, or has a neighbouring block update, to re-detect dynamic properties which
* are not saved on the world.
*
* Clears any cached precomputed objects, such as bounding boxes. Remove any outdated precomputed things such as
* AABBs and force recalculation.
*/
public function readStateFromWorld() : void{
$this->boundingBox = null;
$this->collisionBoxes = null;
}
public function writeStateToWorld() : void{
$this->level->getChunkAtPosition($this)->setBlock($this->x & 0xf, $this->y, $this->z & 0xf, $this->getId(), $this->getDamage());
}
/**
* Returns a bitmask used to extract state bits from block metadata.
*
@ -448,7 +464,7 @@ class Block extends Position implements BlockIds, Metadatable{
$this->y = (int) $v->y;
$this->z = (int) $v->z;
$this->level = $v->level;
$this->updateState();
$this->readStateFromWorld();
}
/**
@ -717,18 +733,6 @@ class Block extends Position implements BlockIds, Metadatable{
return AxisAlignedBB::one();
}
/**
* Called when this block is created, set, or has a neighbouring block update, to re-detect dynamic properties which
* are not saved on the world.
*
* Clears any cached precomputed objects, such as bounding boxes. Remove any outdated precomputed things such as
* AABBs and force recalculation.
*/
public function updateState() : void{
$this->boundingBox = null;
$this->collisionBoxes = null;
}
/**
* @param Vector3 $pos1
* @param Vector3 $pos2

4
src/pocketmine/block/CobblestoneWall.php
View File

@ -48,8 +48,8 @@ class CobblestoneWall extends Transparent{
return 2;
}
public function updateState() : void{
parent::updateState();
public function readStateFromWorld() : void{
parent::readStateFromWorld();
foreach(Facing::HORIZONTAL as $facing){
$block = $this->getSide($facing);

4
src/pocketmine/block/Door.php
View File

@ -69,8 +69,8 @@ abstract class Door extends Transparent{
return 0b1111;
}
public function updateState() : void{
parent::updateState();
public function readStateFromWorld() : void{
parent::readStateFromWorld();
//copy door properties from other half
$other = $this->getSide($this->top ? Facing::DOWN : Facing::UP);

4
src/pocketmine/block/Fence.php
View File

@ -34,8 +34,8 @@ abstract class Fence extends Transparent{
return 0.25;
}
public function updateState() : void{
parent::updateState();
public function readStateFromWorld() : void{
parent::readStateFromWorld();
foreach(Facing::HORIZONTAL as $facing){
$block = $this->getSide($facing);

4
src/pocketmine/block/Liquid.php
View File

@ -118,8 +118,8 @@ abstract class Liquid extends Transparent{
return $block->falling ? 0 : $block->decay;
}
public function updateState() : void{
parent::updateState();
public function readStateFromWorld() : void{
parent::readStateFromWorld();
$this->flowVector = null;
}

25
src/pocketmine/block/Skull.php
View File

@ -59,8 +59,8 @@ class Skull extends Flowable{
return 0b111;
}
public function updateState() : void{
parent::updateState();
public function readStateFromWorld() : void{
parent::readStateFromWorld();
$tile = $this->level->getTile($this);
if($tile instanceof TileSkull){
$this->type = $tile->getType();
@ -68,6 +68,15 @@ class Skull extends Flowable{
}
}
public function writeStateToWorld() : void{
parent::writeStateToWorld();
$tile = Tile::createTile(Tile::SKULL, $this->getLevel(), TileSkull::createNBT($this));
if($tile instanceof TileSkull){
$tile->setRotation($this->rotation);
$tile->setType($this->type);
}
}
public function getHardness() : float{
return 1;
}
@ -91,17 +100,7 @@ class Skull extends Flowable{
if($player !== null and $face === Facing::UP){
$this->rotation = ((int) floor(($player->yaw * 16 / 360) + 0.5)) & 0xf;
}
if(parent::place($item, $blockReplace, $blockClicked, $face, $clickVector, $player)){
//TODO: make this automatic on block set
$tile = Tile::createTile(Tile::SKULL, $this->getLevel(), TileSkull::createNBT($this));
if($tile instanceof TileSkull){
$tile->setRotation($this->rotation);
$tile->setType($this->type);
}
return true;
}
return false;
return parent::place($item, $blockReplace, $blockClicked, $face, $clickVector, $player);
}
public function getItem() : Item{

11
src/pocketmine/level/Level.php
View File

@ -762,7 +762,7 @@ class Level implements ChunkManager, Metadatable{
Level::getBlockXYZ($index, $x, $y, $z);
$block = $this->getBlockAt($x, $y, $z);
$block->updateState(); //for blocks like fences, force recalculation of connected AABBs
$block->readStateFromWorld(); //for blocks like fences, force recalculation of connected AABBs
$ev = new BlockUpdateEvent($block);
$ev->call();
@ -1372,7 +1372,7 @@ class Level implements ChunkManager, Metadatable{
$block->y = $y;
$block->z = $z;
$block->level = $this;
$block->updateState();
$block->readStateFromWorld();
if($addToCache and $blockHash !== null){
$this->blockCache[$chunkHash][$blockHash] = $block;
@ -1517,7 +1517,6 @@ class Level implements ChunkManager, Metadatable{
$this->timings->setBlock->startTiming();
if($this->getChunkAtPosition($pos, true)->setBlock($pos->x & 0x0f, $pos->y, $pos->z & 0x0f, $block->getId(), $block->getDamage())){
if(!($pos instanceof Position)){
$pos = $this->temporalPosition->setComponents($pos->x, $pos->y, $pos->z);
}
@ -1525,6 +1524,7 @@ class Level implements ChunkManager, Metadatable{
$block = clone $block;
$block->position($pos);
$block->writeStateToWorld();
$chunkHash = Level::chunkHash($pos->x >> 4, $pos->z >> 4);
$blockHash = Level::blockHash($pos->x, $pos->y, $pos->z);
@ -1559,11 +1559,6 @@ class Level implements ChunkManager, Metadatable{
return true;
}
$this->timings->setBlock->stopTiming();
return false;
}
/**
* @param Vector3 $source
* @param Item $item