mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-07-06 01:51:51 +00:00
Code Issues Projects Releases Wiki Activity

LightArray: hide constants ZERO and FIFTEEN from the API

Browse Source 
this makes it easier to implement this in C++ with the same API. Since the C++ version doesn't use strings, these constants aren't needed anyway.
This commit is contained in:
Dylan K. Taylor 2020-09-08 15:13:58 +01:00
parent 01f8116cdd
commit 0fd3d91038
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/world/format/EmptySubChunk.php
View File

@ -56,10 +56,10 @@ class EmptySubChunk implements SubChunkInterface{
} }
public function getBlockLightArray() : LightArray{ public function getBlockLightArray() : LightArray{
return new LightArray(LightArray::ZERO); return LightArray::fill(0);
} }
public function getBlockSkyLightArray() : LightArray{ public function getBlockSkyLightArray() : LightArray{
return new LightArray(LightArray::FIFTEEN); return LightArray::fill(15);
} }
} }

4
src/world/format/LightArray.php
View File

@ -39,8 +39,8 @@ if(!defined(__NAMESPACE__ . '\FIFTEEN_NIBBLE_ARRAY')){
final class LightArray{ final class LightArray{
public const ZERO = ZERO_NIBBLE_ARRAY; private const ZERO = ZERO_NIBBLE_ARRAY;
public const FIFTEEN = FIFTEEN_NIBBLE_ARRAY; private const FIFTEEN = FIFTEEN_NIBBLE_ARRAY;
/** @var string */ /** @var string */
private $data; private $data;

4
src/world/format/SubChunk.php
View File

@ -46,8 +46,8 @@ class SubChunk implements SubChunkInterface{
$this->defaultBlock = $default; $this->defaultBlock = $default;
$this->blockLayers = $blocks; $this->blockLayers = $blocks;
$this->skyLight = $skyLight ?? new LightArray(LightArray::FIFTEEN); $this->skyLight = $skyLight ?? LightArray::fill(15);
$this->blockLight = $blockLight ?? new LightArray(LightArray::ZERO); $this->blockLight = $blockLight ?? LightArray::fill(0);
} }
public function isEmptyAuthoritative() : bool{ public function isEmptyAuthoritative() : bool{