From 0e64d4bbc222fedf28109affb3b50a5b1ca0854f Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 20 Mar 2017 12:21:02 +0000 Subject: [PATCH] Given Player->iusername a use, added Player->getLowerCaseName() Micro optimizations by not repeatedly lowercasing names when searching --- src/pocketmine/Player.php | 7 +++++++ src/pocketmine/Server.php | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/pocketmine/Player.php b/src/pocketmine/Player.php index b0c448d95..324404d0f 100644 --- a/src/pocketmine/Player.php +++ b/src/pocketmine/Player.php @@ -3571,6 +3571,13 @@ class Player extends Human implements CommandSender, InventoryHolder, ChunkLoade return $this->username; } + /** + * @return string + */ + public function getLowerCaseName() : string{ + return $this->iusername; + } + public function kill(){ if(!$this->spawned){ return; diff --git a/src/pocketmine/Server.php b/src/pocketmine/Server.php index 3bf61a76f..1ab35324c 100644 --- a/src/pocketmine/Server.php +++ b/src/pocketmine/Server.php @@ -817,7 +817,7 @@ class Server{ public function getPlayerExact($name){ $name = strtolower($name); foreach($this->getOnlinePlayers() as $player){ - if(strtolower($player->getName()) === $name){ + if($player->getLowerCaseName() === $name){ return $player; } } @@ -834,7 +834,7 @@ class Server{ $partialName = strtolower($partialName); $matchedPlayers = []; foreach($this->getOnlinePlayers() as $player){ - if(strtolower($player->getName()) === $partialName){ + if($player->getLowerCaseName() === $partialName){ $matchedPlayers = [$player]; break; }elseif(stripos($player->getName(), $partialName) !== false){