mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-06-06 11:57:10 +00:00
Code Issues Projects Releases Wiki Activity

Re-added basic chunk skylight population for GenericChunk (#183)

Browse Source
This commit is contained in:
Tim (robske_110) 2016-12-29 11:45:23 +00:00 committed by Dylan K. Taylor
parent 850afed2c6
commit 0c3780de40
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/pocketmine/level/format/generic/GenericChunk.php
View File

@ -54,7 +54,7 @@ class GenericChunk implements Chunk{
protected $terrainGenerated = false;
protected $terrainPopulated = false;
protected $height = 16;
protected $height = Chunk::MAX_SUBCHUNKS;
/** @var SubChunk[] */
protected $subChunks = [];
@ -119,7 +119,8 @@ class GenericChunk implements Chunk{
$this->heightMap = $heightMap;
}else{
assert(count($heightMap) === 0, "Wrong HeightMap value count, expected 256, got " . count($heightMap));
$this->heightMap = array_fill(0, 256, 0);
$val = ($this->height * 16) - 1;
$this->heightMap = array_fill(0, 256, $val);
}
if(strlen($biomeIds) === 256){
@ -271,27 +272,28 @@ class GenericChunk implements Chunk{
}
public function populateSkyLight(){
/*for($x = 0; $x < 16; ++$x){
//TODO: rewrite this, use block light filters and diffusion, actual proper sky light population
for($x = 0; $x < 16; ++$x){
for($z = 0; $z < 16; ++$z){
$top = $this->getHeightMap($x, $z);
$heightMap = $this->getHeightMap($x, $z);
$y = min($this->getHighestSubChunkIndex() << 4, $heightMap);
//$subChunk = $this->getSubChunk()
for($y = 127; $y > $top; --$y){
for(; $y > $heightMap; --$y){
$this->setBlockSkyLight($x, $y, $z, 15);
}
for($y = $top; $y >= 0; --$y){
if(Block::$solid[$this->getBlockId($x, $y, $z)]){
for(; $y > 0; --$y){
if($this->getBlockId($x, $y, $z) !== Block::AIR){
break;
}
$this->setBlockSkyLight($x, $y, $z, 15);
}
$this->setHeightMap($x, $z, $this->getHighestBlockAt($x, $z, false));
$this->setHeightMap($x, $z, $y);
}
}*/
}
}
public function getBiomeId(int $x, int $z) : int{
@ -763,4 +765,4 @@ class GenericChunk implements Chunk{
return $result;
}
}
}