mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-16 02:38:54 +00:00
Code Issues Projects Releases Wiki Activity

World: formalize setBlockAt()'s refusal to modify un-generated chunks

Browse Source 
closes #2631
This commit is contained in:
Dylan K. Taylor 2020-11-01 17:24:09 +00:00
parent b7690fed04
commit 0bb37b5065
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/world/World.php
View File

@ -1401,6 +1401,14 @@ class World implements ChunkManager{
if(!$this->isInWorld($x, $y, $z)){ if(!$this->isInWorld($x, $y, $z)){
throw new \InvalidArgumentException("Pos x=$x,y=$y,z=$z is outside of the world bounds"); throw new \InvalidArgumentException("Pos x=$x,y=$y,z=$z is outside of the world bounds");
} }
$chunkX = $x >> 4;
$chunkZ = $z >> 4;
if($this->isChunkLocked($chunkX, $chunkZ)){
throw new WorldException("Terrain is locked for generation/population");
}
if(!$this->loadChunk($chunkX, $chunkZ, false)){ //current expected behaviour is to try to load the terrain synchronously
throw new WorldException("Cannot set a block in un-generated terrain");
}
$this->timings->setBlock->startTiming(); $this->timings->setBlock->startTiming();