mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-07 18:32:55 +00:00
Code Issues Projects Releases Wiki Activity

Improve BlockFactory initialization performance

Browse Source 
as expected, expanding data range unconditionally resulted in some performance issues ...
This commit is contained in:
Dylan K. Taylor
2022-06-27 15:37:05 +01:00
parent bedc9cf518
commit 0afb67be7d
75 changed files with 169 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/block/Block.php
View File

@ -100,9 +100,16 @@ class Block{
return 0;
}
public function getRequiredStateDataBits() : int{ return 0; }
public function decodeStateData(int $data) : void{
$reader = new BlockDataReader(self::INTERNAL_STATE_DATA_BITS, $data);
$givenBits = $this->getRequiredStateDataBits();
$reader = new BlockDataReader($givenBits, $data);
$this->decodeState($reader);
$readBits = $reader->getOffset();
if($givenBits !== $readBits){
throw new \LogicException("Exactly $givenBits bits of state data were provided, but only $readBits were read");
}
}
protected function decodeState(BlockDataReader $r) : void{
@ -113,8 +120,14 @@ class Block{
* @internal
*/
public function computeStateData() : int{
$writer = new BlockDataWriter(self::INTERNAL_STATE_DATA_BITS);
$requiredBits = $this->getRequiredStateDataBits();
$writer = new BlockDataWriter($requiredBits);
$this->encodeState($writer);
$writtenBits = $writer->getOffset();
if($requiredBits !== $writtenBits){
throw new \LogicException("Exactly $requiredBits bits of state data were expected, but only $writtenBits were written");
}
return $writer->getValue();
}