mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-06 01:46:04 +00:00
Code Issues Projects Releases Wiki Activity

FastChunkSerializer: retain emptyBlock on subchunks

Browse Source 
I think we should probably get rid of this considering the potential for inconsistencies within a chunk, but not retaining this is a bug nonetheless, even though it doesn't have any effect in PM itself since we always use BlockLegacyIds << 4 as the empty block ID.

so, this is only really aiding (ab)use cases which weren't intended anyway ...
This commit is contained in:
Dylan K. Taylor
2020-11-27 13:41:35 +00:00
parent 4e94025b3b
commit 0a7d81a2b0
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/world/format/SubChunk.php
View File

@ -69,6 +69,12 @@ class SubChunk{
return count($this->blockLayers) === 0;
}
/**
* Returns the block used as the default. This is assumed to refer to air.
* If all the blocks in a subchunk layer are equal to this block, the layer is assumed to be empty.
*/
public function getEmptyBlockId() : int{ return $this->emptyBlockId; }
public function getFullBlock(int $x, int $y, int $z) : int{
if(count($this->blockLayers) === 0){
return $this->emptyBlockId;