mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-04 00:55:14 +00:00
Code Issues Projects Releases Wiki Activity

Clean up terminology around block state IDs and their handling

Browse Source
This commit is contained in:
Dylan K. Taylor
2023-01-25 18:53:11 +00:00
parent 2f469ef4a0
commit 0a3ecfdae9
30 changed files with 81 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/phpunit/block/BlockTest.php
View File

@ -33,11 +33,11 @@ use const SORT_STRING;
class BlockTest extends TestCase{
/** @var BlockFactory */
/** @var RuntimeBlockStateRegistry */
private $blockFactory;
public function setUp() : void{
$this->blockFactory = new BlockFactory();
$this->blockFactory = new RuntimeBlockStateRegistry();
}
/**

6
tests/phpunit/block/regenerate_consistency_check.php
View File

@ -22,17 +22,17 @@
declare(strict_types=1);
use pocketmine\block\Block;
use pocketmine\block\BlockFactory;
use pocketmine\block\RuntimeBlockStateRegistry;
use pocketmine\utils\AssumptionFailedError;
require dirname(__DIR__, 3) . '/vendor/autoload.php';
/* This script needs to be re-run after any intentional blockfactory change (adding or removing a block state). */
$factory = new \pocketmine\block\BlockFactory();
$factory = new \pocketmine\block\RuntimeBlockStateRegistry();
$remaps = [];
$new = [];
foreach(BlockFactory::getInstance()->getAllKnownStates() as $index => $block){
foreach(RuntimeBlockStateRegistry::getInstance()->getAllKnownStates() as $index => $block){
if($index !== $block->getStateId()){
throw new AssumptionFailedError("State index should always match state ID");
}