mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 02:42:58 +00:00
Code Issues Projects Releases Wiki Activity

Avoid dodgy array_flip hash building

Browse Source 
the conventional way is using array_keys and array_fill_keys. Behaviour is more predictable & also avoids benevolent union fuckery from PHPStan.
This commit is contained in:
Dylan K. Taylor
2025-01-08 01:45:28 +00:00
parent e34f34f9f4
commit 0a16daa619
2 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugin/PluginGraylist.php
View File

@ -24,7 +24,8 @@ declare(strict_types=1);
namespace pocketmine\plugin;
use pocketmine\utils\Utils;
use function array_flip;
use function array_fill_keys;
use function array_keys;
use function is_array;
use function is_float;
use function is_int;
@ -32,23 +33,28 @@ use function is_string;
class PluginGraylist{
/** @var string[] */
/**
* @var true[]
* @phpstan-var array<string, true>
*/
private array $plugins;
private bool $isWhitelist = false;
/**
* @param string[] $plugins
* @phpstan-param list<string> $plugins
*/
public function __construct(array $plugins = [], bool $whitelist = false){
$this->plugins = array_flip($plugins);
$this->plugins = array_fill_keys($plugins, true);
$this->isWhitelist = $whitelist;
}
/**
* @return string[]
* @phpstan-return list<string>
*/
public function getPlugins() : array{
return array_flip($this->plugins);
return array_keys($this->plugins);
}
public function isWhitelist() : bool{